Clean up code with `mode`.

Akinori MUSHA %!s(int64=10) %!d(string=hace) años
padre
commit
0227496669
Se han modificado 1 ficheros con 8 adiciones y 8 borrados
  1. 8 8
      app/models/agents/website_agent.rb

+ 8 - 8
app/models/agents/website_agent.rb

@@ -223,11 +223,8 @@ module Agents
223 223
     # If mode is set to 'on_change', this method may return false and update an existing
224 224
     # event to expire further in the future.
225 225
     def store_payload!(old_events, result)
226
-      if !interpolated['mode'].present?
227
-        return true
228
-      elsif interpolated['mode'].to_s == "all"
229
-        return true
230
-      elsif interpolated['mode'].to_s == "on_change"
226
+      case interpolated['mode'].presence
227
+      when 'on_change'
231 228
         result_json = result.to_json
232 229
         old_events.each do |old_event|
233 230
           if old_event.payload.to_json == result_json
@@ -236,9 +233,12 @@ module Agents
236 233
             return false
237 234
           end
238 235
         end
239
-        return true
236
+        true
237
+      when 'all', ''
238
+        true
239
+      else
240
+        raise "Illegal options[mode]: #{interpolated['mode']}"
240 241
       end
241
-      raise "Illegal options[mode]: " + interpolated['mode'].to_s
242 242
     end
243 243
 
244 244
     def previous_payloads(num_events)
@@ -251,7 +251,7 @@ module Agents
251 251
           look_back = UNIQUENESS_LOOK_BACK
252 252
         end
253 253
       end
254
-      events.order("id desc").limit(look_back) if interpolated['mode'].present? && interpolated['mode'].to_s == "on_change"
254
+      events.order("id desc").limit(look_back) if interpolated['mode'] == "on_change"
255 255
     end
256 256
 
257 257
     def extract_full_json?